SQL client uses test containers + JDBC URL added to ProgramEnvironment #452
+8,406
−283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaidioz
force-pushed
the
sql-client-test-container
branch
3 times, most recently
from
3b49b01 to
01f1fe9
Compare
bgaidioz
changed the title
bgaidioz
force-pushed
the
sql-client-test-container
branch
3 times, most recently
from
4d9ff21 to
83d656a
Compare
miguelbranco80
approved these changes
Jun 28, 2024
sql-client/src/main/scala/raw/client/sql/SqlCompilerService.scala
Outdated
Show resolved
Hide resolved
bgaidioz
force-pushed
the
sql-client-test-container
branch
from
3684f60 to
a001962
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset includes:
jdbcUrlto theProgramEnvironmentso that the SQL compiler can just retrieve it before running a query or anything.sqlClientonraw.snapi.frontend(removal ofCredentialsServiceuse) andraw.sourcesthat was there by copy-paste accident.